Skip to content

NETOBSERV-2477: prevent displaying invalid scopes#2519

Open
jotak wants to merge 1 commit intonetobserv:mainfrom
jotak:prevent-invalid-scopes
Open

NETOBSERV-2477: prevent displaying invalid scopes#2519
jotak wants to merge 1 commit intonetobserv:mainfrom
jotak:prevent-invalid-scopes

Conversation

@jotak
Copy link
Member

@jotak jotak commented Mar 10, 2026

Description

Amend web console config relatively to configured metrics. When the configured metrics don't allow to use a given scope, just don't configure that scope in the console.

Dependencies

n/a

Checklist

  • Does the changes in PR need specific configuration or environment set up for testing?
    • if so please describe it in PR description.
  • I have added thorough unit tests for the change.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 10, 2026 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-2477 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Amend web console config relatively to configured metrics. When the configured metrics don't allow to use a given scope, just don't configure that scope in the console.

Dependencies

n/a

Checklist

  • Does the changes in PR need specific configuration or environment set up for testing?
    • if so please describe it in PR description.
  • I have added thorough unit tests for the change.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak mentioned this pull request Mar 10, 2026
Closed
10 tasks
@jotak jotak added the needs-review Tells that the PR needs a review label Mar 12, 2026
@jotak
NETOBSERV-2477: prevent displaying invalid scopes
cc2ef75 
Amend web console config relatively to configured metrics. When the
configured metrics don't allow to use a given scope, just don't
configure that scope in the console.
@jotak jotak force-pushed the prevent-invalid-scopes branch from d101478 to cc2ef75 Compare March 12, 2026 15:31
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 12, 2026
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

New images:

quay.io/netobserv/network-observability-operator:af219cc
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-af219cc
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-af219cc

They will expire in two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:af219cc make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-af219cc

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-af219cc
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@codecov
Copy link

codecov bot commented Mar 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.25%. Comparing base (fb8e810) to head (cc2ef75).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../controller/consoleplugin/consoleplugin_objects.go 95.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
+ Coverage   71.99%   72.25%   +0.26%     
==========================================
  Files         105      105              
  Lines       10762    10802      +40     
==========================================
+ Hits         7748     7805      +57     
+ Misses       2529     2519      -10     
+ Partials      485      478       -7
Flag Coverage Δ
unittests 72.25% <95.34%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller/consoleplugin/consoleplugin_objects.go 89.84% <95.34%> (+2.37%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

leandroberetta
leandroberetta approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 12, 2026
@jotak jotak removed the needs-review Tells that the PR needs a review label Mar 16, 2026
@Amoghrd
Copy link
Member

Amoghrd commented Mar 16, 2026

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroberetta leandroberetta leandroberetta approved these changes

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

@luisjira luisjira Awaiting requested review from luisjira

Assignees

@leandroberetta leandroberetta

Labels

jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jotak @openshift-ci-robot @Amoghrd @leandroberetta